Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to item-container.add() method. #340

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Add check to item-container.add() method. #340

merged 2 commits into from
Aug 10, 2021

Conversation

src52
Copy link
Contributor

@src52 src52 commented Aug 10, 2021

Ensures that items added to an item container don't have a quantity of zero.

Spencer Carlson and others added 2 commits August 10, 2021 14:41
Add:
0149cef 
A check in iten-container.add() method to ensure items added don't have quantity of zero.
@src52
Merge branch 'runejs:develop' into no-zero-items
e59385d
@src52 src52 mentioned this pull request Aug 10, 2021
Closed
Tynarus
Tynarus approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@Tynarus Tynarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Tynarus Tynarus merged commit b1f077a into runejs:develop Aug 10, 2021
@SchauweM SchauweM linked an issue Aug 11, 2021 that may be closed by this pull request
[BUG] Coins are not removed from inventory when 0 #331
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tynarus Tynarus Tynarus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Coins are not removed from inventory when 0
2 participants
@src52 @Tynarus